Add gallery example for OEDI system 9068#1985
Conversation
There was a problem hiding this comment.
I would expose the other loss parameters:
# Other loss types are left at their default amounts.
losses_parameters = dict(shading=0, availability=0)
Otherwise things look good to me.
I have my doubts if applying a transient operation on the module temperature makes this any more accurate when you use satellite data?
Maybe add a note about why you're not using the measured irradiance (I think that would be useful for people)
A shame that this great data initiative has so poor metadata - a bit ironic really.
5-minute PSM3 data is very "spiky", so using a transient model at least makes the modeled Tcell more realistic/smooth, if not also more accurate. IMHO it's reasonable to include by default unless we know for some reason that it makes results worse. I think SAM applies it by default for any dataset with time step below 20 minutes.
It does say this before fetching the weather dataset:
|
It could actually be instructive to use that measured data in the example anyway. |
3 participants
[ ] Tests added[ ] Updates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.